Skip to content

Commit

Permalink
Merge pull request #1476 from ably/release/1.2.13
Browse files Browse the repository at this point in the history
Release/1.2.13
  • Loading branch information
lawrence-forooghian authored Aug 18, 2022
2 parents 597bb6f + 2012480 commit 8f3cd7e
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 8 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

## [1.2.13](https://github.com/ably/ably-cocoa/tree/1.2.13)

[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.12...1.2.13)

**Fixed bugs:**

- Warnings of the form `Umbrella header for module 'Ably' does not include header 'ARTPushActivationEvent.h'` (fixed by [\#1474](https://github.com/ably/ably-cocoa/pull/1474))

## [1.2.12](https://github.com/ably/ably-cocoa/tree/1.2.12)

[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.11...1.2.12)
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ You can install Ably for iOS and macOS through Package Manager, CocoaPods, Carth
- [This apple guide](https://developer.apple.com/documentation/swift_packages/adding_package_dependencies_to_your_app) explains the steps in more detail.
- To install the `ably-cocoa` package in another **Swift Package**, then add the following to your `Package.Swift`:
```swift
.package(url: "https://github.com/ably/ably-cocoa", from: "1.2.12"),
.package(url: "https://github.com/ably/ably-cocoa", from: "1.2.13"),
```
### Installing through [CocoaPods](https://cocoapods.org/)

Expand Down Expand Up @@ -103,7 +103,7 @@ If you see, for example, a `dyld: Library not loaded: @rpath/AblyDeltaCodec.fram

### Manual installation

1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.12), or clone it to get the latest, unstable and possibly underdocumented version: `git clone [email protected]:ably/ably-cocoa.git`
1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.13), or clone it to get the latest, unstable and possibly underdocumented version: `git clone [email protected]:ably/ably-cocoa.git`
2. Drag the directory `ably-cocoa/ably-cocoa` into your project as a group.
3. Ably depends on our [MessagePack Fork](https://github.com/ably-forks/msgpack-objective-C) 0.2.0; get it [from the releases page](https://github.com/ably-forks/msgpack-objective-C/releases/tag/0.2.0-ably-1) and link it into your project.

Expand Down
2 changes: 1 addition & 1 deletion Scripts/jazzy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jazzy \
--objc \
--clean \
--author Ably \
--module-version 1.2.12 \
--module-version 1.2.13 \
--umbrella-header Source/Ably.h \
--framework-root . \
--module Ably \
Expand Down
2 changes: 1 addition & 1 deletion Source/ARTDefault.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ static inline UInt32 conformVersionComponent(const NSInteger component) {
}

NSString *const ARTDefault_apiVersion = @"1.2";
NSString *const ARTDefault_libraryVersion = @"1.2.12";
NSString *const ARTDefault_libraryVersion = @"1.2.13";

NSString *const ARTDefaultProduction = @"production";

Expand Down
2 changes: 1 addition & 1 deletion Spec/Tests/ARTDefaultTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ class ARTDefaultTests: XCTestCase {

func testVersions() {
XCTAssertEqual(ARTDefault.apiVersion(), "1.2")
XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.12")
XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.13")
}
}
2 changes: 1 addition & 1 deletion Spec/Tests/RealtimeClientConnectionTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ class RealtimeClientConnectionTests: XCTestCase {
done()
case .connected:
if let transport = client.internal.transport as? TestProxyTransport, let query = transport.lastUrl?.query {
expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.12"))
expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.13"))
} else {
XCTFail("MockTransport isn't working")
}
Expand Down
2 changes: 1 addition & 1 deletion Spec/Tests/RestClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1668,7 +1668,7 @@ class RestClientTests: XCTestCase {
let headerAgent = testHTTPExecutor.requests.first!.allHTTPHeaderFields?["Ably-Agent"]
let ablyAgent = options.agents()
expect(headerAgent).to(equal(ablyAgent))
expect(headerAgent!.hasPrefix("ably-cocoa/1.2.12")).to(beTrue())
expect(headerAgent!.hasPrefix("ably-cocoa/1.2.13")).to(beTrue())
done()
}
}
Expand Down
2 changes: 1 addition & 1 deletion Version.xcconfig
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CURRENT_PROJECT_VERSION = 1.2.12
CURRENT_PROJECT_VERSION = 1.2.13

0 comments on commit 8f3cd7e

Please sign in to comment.