Merge pull request #1454 from ably/release/1.2.12

Release/1.2.12

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## [1.2.12](https://github.com/ably/ably-cocoa/tree/1.2.12)
+
+[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.11...1.2.12)
+
+**Fixed bugs:**
+
+- SCNetworkReachabilitySetCallback (Crashed: io.ably.main) [\#1380](https://github.com/ably/ably-cocoa/issues/1380), fixed in: Fix of the crash in the `ARTOSReachability` [\#1453](https://github.com/ably/ably-cocoa/pull/1453) ([maratal](https://github.com/maratal))
+- Channel names are not properly url-encoded [\#1449](https://github.com/ably/ably-cocoa/issues/1449), fixed in: Fixed channel name url encoding [\#1451](https://github.com/ably/ably-cocoa/pull/1451) ([maratal](https://github.com/maratal))
+
 ## [1.2.11](https://github.com/ably/ably-cocoa/tree/1.2.11)
 
 [Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.10...1.2.11)

README.md

@@ -60,7 +60,7 @@ You can install Ably for iOS and macOS through Package Manager, CocoaPods, Carth
     - [This apple guide](https://developer.apple.com/documentation/swift_packages/adding_package_dependencies_to_your_app) explains the steps in more detail.
 - To install the `ably-cocoa` package in another **Swift Package**, then add the following to your `Package.Swift`:
 ```swift
- .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.11"),
+ .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.12"),
 ```
 ### Installing through [CocoaPods](https://cocoapods.org/)
 
@@ -103,7 +103,7 @@ If you see, for example, a `dyld: Library not loaded: @rpath/AblyDeltaCodec.fram
 
 ### Manual installation 
 
-1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.11), or clone it to get the latest, unstable and possibly underdocumented version: `git clone [email protected]:ably/ably-cocoa.git`
+1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.12), or clone it to get the latest, unstable and possibly underdocumented version: `git clone [email protected]:ably/ably-cocoa.git`
 2. Drag the directory `ably-cocoa/ably-cocoa` into your project as a group.
 3. Ably depends on our [MessagePack Fork](https://github.com/ably-forks/msgpack-objective-C) 0.2.0; get it [from the releases page](https://github.com/ably-forks/msgpack-objective-C/releases/tag/0.2.0-ably-1) and link it into your project.
 

Scripts/jazzy.sh

@@ -7,7 +7,7 @@ jazzy \
   --objc \
   --clean \
   --author Ably \
-  --module-version 1.2.11 \
+  --module-version 1.2.12 \
   --umbrella-header Source/Ably.h \
   --framework-root . \
   --module Ably \

Source/ARTDefault.m

@@ -9,7 +9,7 @@ static inline UInt32 conformVersionComponent(const NSInteger component) {
 }
 
 NSString *const ARTDefault_apiVersion = @"1.2";
-NSString *const ARTDefault_libraryVersion = @"1.2.11";
+NSString *const ARTDefault_libraryVersion = @"1.2.12";
 
 NSString *const ARTDefaultProduction = @"production";
 

Spec/Tests/ARTDefaultTests.swift

@@ -6,6 +6,6 @@ class ARTDefaultTests: XCTestCase {
 
     func testVersions() {
         XCTAssertEqual(ARTDefault.apiVersion(), "1.2")
-        XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.11")
+        XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.12")
     }
 }

Spec/Tests/RealtimeClientConnectionTests.swift

@@ -378,7 +378,7 @@ class RealtimeClientConnectionTests: XCTestCase {
                     done()
                 case .connected:
                     if let transport = client.internal.transport as? TestProxyTransport, let query = transport.lastUrl?.query {
-                        expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.11"))
+                        expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.12"))
                     } else {
                         XCTFail("MockTransport isn't working")
                     }

Spec/Tests/RestClientTests.swift

@@ -1668,7 +1668,7 @@ class RestClientTests: XCTestCase {
                 let headerAgent = testHTTPExecutor.requests.first!.allHTTPHeaderFields?["Ably-Agent"]
                 let ablyAgent = options.agents()
                 expect(headerAgent).to(equal(ablyAgent))
-                expect(headerAgent!.hasPrefix("ably-cocoa/1.2.11")).to(beTrue())
+                expect(headerAgent!.hasPrefix("ably-cocoa/1.2.12")).to(beTrue())
                 done()
             }
         }

Version.xcconfig

@@ -1 +1 @@
-CURRENT_PROJECT_VERSION = 1.2.11
+CURRENT_PROJECT_VERSION = 1.2.12