[ECO-4900] First attempt at defining public API #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mistake in 646c220.
lawrence-forooghian
force-pushed
the
ECO-4900-public-interface
branch
from
e59e032 to
61ae43f
Compare
Based on JS at 0b4b0f8. The entry point is the DefaultChatClient class. Chose to use existential types when one protocol returns another (i.e. `-> any MyProtocol`) instead of associated types, because it’s more readable and I don’t think that we need to worry about the performance implications. turned on explicit_acl, but just for the library — it's a handy thing to have to make sure you've not missed making anything public, but we don’t need it for BuildTool (For future reference, generate memberwise initializers in Xcode by clicking at the start of the type declaration and doing Editor -> Refactor -> Generate Memberwise Initializer.) Skipped copying the docstrings from JS; created #1 to do this later. Turned off missing_docs for now. We’ll be able to validate this API when we do #4, which will create a mock implementation of this API and then build the example app around the mock. Some stuff is up in the air until we start trying to implement, too. maybe have been too liberal with Sendable not sure if the types where `subscribe()` just returns a subscription could be sequences themselves, i still don't understand the nuance of buffering and whatnot, what happens if you share them so the api decided on is that there are no responses, you can directly iterate over what comes out (because there’s no need for an `off()`)
lawrence-forooghian
force-pushed
the
ECO-4900-public-interface
branch
from
61ae43f to
4c2c98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.