Implement the Subscription type
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
lawrence-forooghian
force-pushed
the
implement-Subscription
branch
5 times, most recently
from
4dd98f5 to
6e82605
Compare
maratal
reviewed
Aug 23, 2024
lawrence-forooghian
force-pushed
the
7-public-api
branch
from
26d3f2d to
20e7f5f
Compare
It offers some nice convenience features. I don’t think that this package is a controversial inclusion; it’s written by Apple and they had a WWDC session about it. This is the first time I’ve tried adding a new package, and for some reason Xcode didn’t update its xcshareddata Package.resolved automatically, but running `xcodebuild -resolvePackageDependencies` did the trick. Adding this package exposed a couple of issues in our CI setup: 1. the way in which we specify which Swift language version to use — I’ve fixed this 2. Xcode can fail when trying to compile a Package.swift package using “treat warnings as errors” — I’ve had to turn that off
lawrence-forooghian
force-pushed
the
implement-Subscription
branch
2 times, most recently
from
202f70a to
a7ec146
Compare
Done this now. |
|
Made the changes but have a compilation error to fix; might require some changes to #7. Will look into it. |
lawrence-forooghian
force-pushed
the
implement-Subscription
branch
from
a7ec146 to
b15ead1
Compare
|
OK, sorted it. |
maratal
reviewed
Aug 24, 2024
maratal
reviewed
Aug 24, 2024
Note that XCTAssertEqual doesn’t allow you to write `await` inside its arguments, hence the indirection to get the result of a couple of `async let`s. Hopefully we’ll be able to migrate to Swift Testing at some point, which will resolve this; see #21. I’ve also implemented MessageSubscription by wrapping Subscription.
lawrence-forooghian
force-pushed
the
implement-Subscription
branch
from
b15ead1 to
721f10c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #9; please review that one first.
This implements the
Subscriptiontype from #9. It’s a bit messy, but we should be able to get rid of it if we switch to Swift 6 once that's released (see #21).