Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4927] Improve the type of PresenceMember.extras #201

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

lawrence-forooghian
Copy link
Collaborator

Note: This PR is based on top of #200; please review that one first.

Changes the type of PresenceMember.extras from (any Sendable)? to [String: JSONValue]?.

Part of #13.

This will allow us to improve the type of the PresenceMember.extras
property in an upcoming commit.
The type that I gave it in 20e7f5f was just copied from the JS SDK, but
we can do better - make it strongly typed, using a type that’s
consistent with PresenceData.

Part of #13.
Copy link
Collaborator

@umair-ably umair-ably left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Base automatically changed from 84-remove-usage-of-Decodable to main December 18, 2024 13:24
@lawrence-forooghian lawrence-forooghian merged commit a182876 into main Dec 18, 2024
16 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 13-fix-PresenceMember-extras-type branch December 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants