Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] typing indicator #66

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[WIP] typing indicator #66

wants to merge 9 commits into from

Conversation

fliptopbox
Copy link
Contributor

@fliptopbox fliptopbox commented Feb 3, 2022

Description

https://app.asana.com/0/1201481627974576/1201727682050909

When a user is authoring a message:

  • a status message "{user-name} is typing ..." should appear below the message input field
  • when more than one user is typing the total number of people with be added to the status message eg. "Alice Aligator is typing ... and 2 more"

Implimentation:

  • An initial criteria (more than 2 characters) sends the status event and sets a timeout
  • the status message appears below the message input component
  • the timeout is cleared when the message is sent OR the delay expires, which will cause a cancellation event to reset the respective views to their default state.
  • if the text input field is emptied this constitutes a cancellation even

PR Checklist

  • (house cleaning) NPM audit fix

Please use this checklist to track the completeness of your PR. We're always happy to assist you in completing these steps!

  • No linting errors/warnings are introduced.
  • Unit tests are all passing.
  • The feature/fix has been tested locally.
  • The feature/fix satisfies the acceptance criteria described in issue: #.

@fliptopbox fliptopbox self-assigned this Feb 3, 2022
@fliptopbox fliptopbox marked this pull request as draft February 3, 2022 15:26
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net

let clients = [];

channel.presence.get((_, members) => {
const typing = clientId === member.clientId;
Copy link

@cruickshankpg cruickshankpg Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this always going to be true? clientId was defined on line 45 from member and you're then just comparing it back on itself again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants