-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] typing indicator #66
base: main
Are you sure you want to change the base?
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gentle-dune-0fec87f03-66.westeurope.azurestaticapps.net |
let clients = []; | ||
|
||
channel.presence.get((_, members) => { | ||
const typing = clientId === member.clientId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this always going to be true? clientId was defined on line 45 from member and you're then just comparing it back on itself again
Description
https://app.asana.com/0/1201481627974576/1201727682050909
When a user is authoring a message:
Implimentation:
PR Checklist
Please use this checklist to track the completeness of your PR. We're always happy to assist you in completing these steps!