-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comment about AsyncSequence
#62
Conversation
We can’t implement some of the #56 improvements that I hoped Swift 6 would enable, due to them requiring OS support.
WalkthroughThe changes involve an update to a comment in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
Sources/AblyChat/Subscription.swift (1)
Line range hint
1-7
: Approve the updated comment with a minor suggestion.The updated comment provides valuable context about the implementation challenges, potential compiler issues, and future considerations for Swift 6. This information is crucial for developers working on or maintaining this code.
Consider breaking down the long comment into multiple lines for improved readability. Here's a suggested format:
// I wanted to implement this as a protocol (from which `MessageSubscription` would then inherit) // but struggled to do so (see https://forums.swift.org/t/struggling-to-create-a-protocol-that-inherits-from-asyncsequence-with-primary-associated-type/73950 // where someone suggested it's a compiler bug), hence the struct. // I was also hoping that upon switching to Swift 6 we could use AsyncSequence's `Failure` // associated type to simplify the way in which we show that the subscription is non-throwing, // but it turns out this can only be done in macOS 15 etc. // So I think that for now we're stuck with things the way they are.
We can’t implement some of the #56 improvements that I hoped Swift 6 would enable, due to them requiring OS support.
Summary by CodeRabbit
Subscription
struct to clarify challenges and provide resources for further discussion.