Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4982] Implement room release #107

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Commits on Nov 11, 2024

  1. Allow Rooms’s rooms to be mocks

    We want to be able to mock out the upcoming `Room.release()` method.
    lawrence-forooghian committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c51fd92 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Implement room release

    We use the implementation of the RELEASE operation provided by the room
    lifecycle manager, and implement the spec points relating to room map
    bookkeeping and releasing the underlying realtime channels.
    
    Based on [1] at 6f0740a.
    
    I have not implemented the spec points that relate to making sure that a
    room fetch waits for any previous room with the same ID to finish
    releasing; this is a part of the spec which is in flux (currently
    implemented via the INITIALIZING status, which was added to the spec
    after we started implementing the room lifecycle manager and hasn’t been
    implemented in this SDK yet, and soon to be further changed in the spec
    by making room-getting async). We can look at the current state of
    things when we come to do #66.
    
    Part of #47.
    
    [1] ably/specification#200
    lawrence-forooghian committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8daa191 View commit details
    Browse the repository at this point in the history