Skip to content

Commit

Permalink
try on different Xcode versions
Browse files Browse the repository at this point in the history
  • Loading branch information
lawrence-forooghian committed Aug 1, 2024
1 parent 7f0cdbf commit 9f18bbc
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 2 deletions.
21 changes: 20 additions & 1 deletion .github/workflows/check.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Check

# TODO fail-fast or whatever it's called

on:
workflow_dispatch:
pull_request:
Expand All @@ -9,23 +11,40 @@ on:
jobs:
check:
runs-on: macos-latest
# TODO Xcode versions (multiple?)
strategy:
fail-fast: false
matrix:
xcode-version: [15.3, 16-beta]
steps:
- uses: actions/checkout@v4
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: ${{ matrix.xcode-version }}

- run: npm ci

- run: script/format/check
- run: script/lint/check

# https://forums.swift.org/t/warnings-as-errors-for-libraries-frameworks/58393/2
- run: swift build -Xswiftc -warnings-as-errors
- run: swift test

check-on-platforms:
runs-on: macos-latest

strategy:
matrix:
fail-fast: false
xcode-version: [15.3, 16-beta]
platform: [macOS, iOS, tvOS]

steps:
- uses: actions/checkout@v4
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: ${{ matrix.xcode-version }}

# TODO OS version, and ambiguity in platforms, and no match
- run: xcodebuild -scheme AblyChat -destination "platform=${{ matrix.platform }}"
- run: xcodebuild test -scheme AblyChat -destination "platform=${{ matrix.platform }}"
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,7 @@ and then we also take the minimum of these and ably-cocoa (which at time of writ
TODO let's see what Xcode 16 says too though — OK, doesn’t seem any different in Beta 3

TODO we probably also have to take into account which simulators are available on the version of Xcode we're using, _and_ which are installed on the GitHub runner

## Xcode versions

TODO explain how we choose which Xcode version to test on
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ TODO

## Requirements

- Swift 5.10 (that is, Xcode 15.3) or later
- Swift 5.10 (that is, Xcode 15.3) or later (TODO choose what's right to use here)

0 comments on commit 9f18bbc

Please sign in to comment.