Skip to content

Commit

Permalink
Remove local swiftlint - checking if this is causing CI linting to fa…
Browse files Browse the repository at this point in the history
…il due to out of memory error
  • Loading branch information
umair-ably committed Sep 30, 2024
1 parent 12b49cf commit 7fc0577
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 82 deletions.
74 changes: 1 addition & 73 deletions AblyChat.xcworkspace/xcshareddata/swiftpm/Package.resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"originHash" : "ec9ce73609e1be2e75429b01afec7e31b1745db9a2ea3fb2c58ab40d00a4ff6f",
"originHash" : "440934a075c7d10a0d3b03a6db6d974a9b21d0a74bca2a826d4504de18d5c779",
"pins" : [
{
"identity" : "ably-cocoa",
Expand All @@ -10,24 +10,6 @@
"revision" : "e20d783d0e8964d9849111a015ea1f5e3c08698c"
}
},
{
"identity" : "collectionconcurrencykit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/JohnSundell/CollectionConcurrencyKit.git",
"state" : {
"revision" : "b4f23e24b5a1bff301efc5e70871083ca029ff95",
"version" : "0.2.0"
}
},
{
"identity" : "cryptoswift",
"kind" : "remoteSourceControl",
"location" : "https://github.com/krzyzanowskim/CryptoSwift.git",
"state" : {
"revision" : "678d442c6f7828def400a70ae15968aef67ef52d",
"version" : "1.8.3"
}
},
{
"identity" : "delta-codec-cocoa",
"kind" : "remoteSourceControl",
Expand All @@ -46,15 +28,6 @@
"version" : "0.4.0"
}
},
{
"identity" : "sourcekitten",
"kind" : "remoteSourceControl",
"location" : "https://github.com/jpsim/SourceKitten.git",
"state" : {
"revision" : "fd4df99170f5e9d7cf9aa8312aa8506e0e7a44e7",
"version" : "0.35.0"
}
},
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
Expand All @@ -81,51 +54,6 @@
"revision" : "9bf03ff58ce34478e66aaee630e491823326fd06",
"version" : "1.1.3"
}
},
{
"identity" : "swift-syntax",
"kind" : "remoteSourceControl",
"location" : "https://github.com/swiftlang/swift-syntax.git",
"state" : {
"revision" : "cb53fa1bd3219b0b23ded7dfdd3b2baff266fd25",
"version" : "600.0.0"
}
},
{
"identity" : "swiftlint",
"kind" : "remoteSourceControl",
"location" : "https://github.com/realm/SwiftLint",
"state" : {
"branch" : "main",
"revision" : "1767dab4858a310719fdf44e6c8dd9dc371503f6"
}
},
{
"identity" : "swiftytexttable",
"kind" : "remoteSourceControl",
"location" : "https://github.com/scottrhoyt/SwiftyTextTable.git",
"state" : {
"revision" : "c6df6cf533d120716bff38f8ff9885e1ce2a4ac3",
"version" : "0.9.0"
}
},
{
"identity" : "swxmlhash",
"kind" : "remoteSourceControl",
"location" : "https://github.com/drmohundro/SWXMLHash.git",
"state" : {
"revision" : "a853604c9e9a83ad9954c7e3d2a565273982471f",
"version" : "7.0.2"
}
},
{
"identity" : "yams",
"kind" : "remoteSourceControl",
"location" : "https://github.com/jpsim/Yams.git",
"state" : {
"revision" : "3036ba9d69cf1fd04d433527bc339dc0dc75433d",
"version" : "5.1.3"
}
}
],
"version" : 3
Expand Down
8 changes: 4 additions & 4 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ let package = Package(
.package(
url: "https://github.com/apple/swift-async-algorithms",
from: "1.0.1"
),
.package(url: "https://github.com/realm/SwiftLint", branch: "main")
)
// .package(url: "https://github.com/realm/SwiftLint", branch: "main")
],
targets: [
.target(
Expand All @@ -40,8 +40,8 @@ let package = Package(
name: "Ably",
package: "ably-cocoa"
),
],
plugins: [.plugin(name: "SwiftLintBuildToolPlugin", package: "SwiftLint")]
]
// plugins: [.plugin(name: "SwiftLintBuildToolPlugin", package: "SwiftLint")]
),
.testTarget(
name: "AblyChatTests",
Expand Down
8 changes: 4 additions & 4 deletions [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ let package = Package(
.package(
url: "https://github.com/apple/swift-async-algorithms",
from: "1.0.1"
),
.package(url: "https://github.com/realm/SwiftLint", branch: "main")
)
// .package(url: "https://github.com/realm/SwiftLint", branch: "main")
],
targets: [
.target(
Expand All @@ -40,8 +40,8 @@ let package = Package(
name: "Ably",
package: "ably-cocoa"
),
],
plugins: [.plugin(name: "SwiftLintBuildToolPlugin", package: "SwiftLint")]
]
// plugins: [.plugin(name: "SwiftLintBuildToolPlugin", package: "SwiftLint")]
),
.testTarget(
name: "AblyChatTests",
Expand Down
2 changes: 1 addition & 1 deletion Sources/AblyChat/ChatAPI.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public final class ChatAPI: Sendable {
internal func getChannel(_ messagesChannelName: String) -> any RealtimeChannelProtocol {
realtime.getChannel(messagesChannelName)
}

// (CHA-M6) Messages should be queryable from a paginated REST API.
public func getMessages(roomId: String, params: QueryOptions) async throws -> any PaginatedResult<Message> {
let endpoint = "/chat/v1/rooms/\(roomId)/messages"
Expand Down

0 comments on commit 7fc0577

Please sign in to comment.