Skip to content

Commit

Permalink
try running on platforms too
Browse files Browse the repository at this point in the history
  • Loading branch information
lawrence-forooghian committed Aug 1, 2024
1 parent 713d53f commit 60a6018
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,12 @@ jobs:
# https://forums.swift.org/t/warnings-as-errors-for-libraries-frameworks/58393/2
- run: swift build -Xswiftc -warnings-as-errors
- run: swift test

check-on-platforms:
strategy:
matrix:
platform: [macOS, iOS, tvOS]
steps:
# TODO OS version, and ambiguity in platforms, and no match
- run: xcodebuild -scheme AblyChat -platform ${{ matrix.platform }}
- run: xcodebuild test -scheme AblyChat -platform ${{ matrix.platform }}
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,5 @@ At time of writing, the latest version of Xcode is 15.4, and the `Package.swift`
and then we also take the minimum of these and ably-cocoa (which at time of writing were all lower than the above)

TODO let's see what Xcode 16 says too though — OK, doesn’t seem any different in Beta 3

TODO we probably also have to take into account which simulators are available on the version of Xcode we're using, _and_ which are installed on the GitHub runner

0 comments on commit 60a6018

Please sign in to comment.