Vulnerabilities corrections

Making static field final to protect them from malicious changes
abinpaul · Mar 5, 2013 · f34b28e · f34b28e
1 parent 00a44ee
commit f34b28e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java b/gridftp/src/main/java/org/globus/ftp/dc/AsciiTranslator.java
@@ -32,7 +32,7 @@ public class AsciiTranslator {
 
     protected byte[] lineSep;
 
-    protected static byte[] systemLineSep;
+    protected final static byte[] systemLineSep;
 
     static {
 	systemLineSep = System.getProperty("line.separator").getBytes();

diff --git a/ssl-proxies/src/main/java/org/globus/gsi/TrustedCertificates.java b/ssl-proxies/src/main/java/org/globus/gsi/TrustedCertificates.java
@@ -85,7 +85,7 @@ public class TrustedCertificates implements Serializable {
      * <caHash>.signing_policy in the same directory as the trusted 
      * certificates.
      */
-    public static String SIGNING_POLICY_FILE_SUFFIX = ".signing_policy";
+    public final static String SIGNING_POLICY_FILE_SUFFIX = ".signing_policy";
 
     private static KeyStore ms_trustStore = null;
     private static CertStore ms_crlStore = null;

diff --git a/ssl-proxies/src/main/java/org/globus/util/PEMUtils.java b/ssl-proxies/src/main/java/org/globus/util/PEMUtils.java
@@ -21,8 +21,8 @@ public class PEMUtils {
 
     static final int LINE_LENGTH = 64;
 
-    public static String lineSep;
-    public static byte[] lineSepBytes;
+    public final static String lineSep;
+    public final static byte[] lineSepBytes;
 
     static {
 	lineSep = System.getProperty("line.separator");