Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuclear weapons analysis #486

Merged
merged 15 commits into from
Jan 9, 2024

Conversation

adi271001
Copy link
Contributor

@adi271001 adi271001 commented Jan 7, 2024

Pull Request for ML-Crate 💡

Issue Title: #392 Nuclear Weapon Analysis and Classification

  • Info about the related issue (Aim of the project) :
  • Name: Aditya D
  • GitHub ID: adi271001
  • Idenitfy yourself: Contributor KWOC

Closes: #issue number that will be closed through this PR #392

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Added new folder nuclear weapons analysis and classification, all requirements satisfied

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Divided Datasets into test and train 20% as test 80 % as train 7 distinct models used

Describe how have you verified the changes made
plotted graphs which is present in images folder which prove that models haven't been under or overfitted

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jan 7, 2024

Our team will soon review your PR. Thanks @adi271001 :)

@abhisheks008 abhisheks008 linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder name should be, Nuclear Weapon Analysis, instead of Nuclear-Weapons-Analysis-And-Classification. Update the folder name, and you are good to go!

@adi271001

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 8, 2024
@adi271001
Copy link
Contributor Author

renamed folder

@abhisheks008
Copy link
Owner

image
Images are not visible.

@adi271001
Copy link
Contributor Author

@abhisheks008 now its visible

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 9, 2024
@abhisheks008
Copy link
Owner

Approved.

@abhisheks008 abhisheks008 merged commit aefd422 into abhisheks008:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuclear Weapons Analysis
2 participants