Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags improvements #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tags improvements #24

wants to merge 2 commits into from

Conversation

rdinit
Copy link

@rdinit rdinit commented Nov 4, 2022

Now tags are clickable and they are displayed on posts list page.

Now tags are clickable and they are displayed on posts list page.
@abhinavs
Copy link
Owner

Thanks a lot for this pull request - really appreciate it.

Can you add a conditional check in post_list.html too. Also, if you can post a screenshot about how it looks, it will be very helpful.

  {% if site.theme_config.show_tags == true %}
    <details>
      <summary>Tags:</summary>
      <ul>
        {% for tag in site.tags %}
          <li>
            <details class="tag">
              <summary>{{ tag[0] }}</summary>
              <span id="{{tag[0]}}">
                <ul>
                  {% for post in tag[1] %}
                    <li>
                      <a href="{{ post.url | relative_url }}">{{ post.title }}</a>
                    </li>
                  {% endfor %}
                </ul>
              </span>
            </details>
          </li>
        {% endfor %}
    </ul>
  </details>
 {% endif %}

@rdinit
Copy link
Author

rdinit commented Nov 12, 2022

https://rdinit.github.io/pagestest/blog#moonwalk - here you can check how it works
image

@abhinavs
Copy link
Owner

abhinavs commented Jan 4, 2023

This seems good, let me take a look at this and add minor changes. Give me a couple of weeks.

(I'm extremely sorry for the delayed response and thank you so much for contributing to this theme. I really appreciate this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants