submit: Invalidate template cache if origin/main is updated #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We calculate the template cache key based on the hashes of the files inside the locations in the repository where tempates are stored, but we check their state at `$trunk` instead of `$remote/$trunk`. This results in the cache not being invalidated if the remote has been updated and fetched, but the local ref is behind. Ref #369
|
This change is part of the following stack: Change managed by git-spice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate the template cache key based on the hashes of the files
inside the locations in the repository where tempates are stored,
but we check their state at
$trunkinstead of$remote/$trunk.This results in the cache not being invalidated
if the remote has been updated and fetched, but the local ref is behind.
Ref #369