Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for control with bluetooth pause/play buttons #118

Merged

Conversation

Anthonyy232
Copy link
Contributor

Implemented bluetooth pause/play with MediaSession

  • Tested on S24 Ultra with Galaxy Buds 2 Pro

@Anthonyy232
Copy link
Contributor Author

Anthonyy232 commented Oct 12, 2024

Should I add a switch preference for this? Or would you want it automatically enabled for everyone?

Edit**
Choice is good, will add

@Eve9181
Copy link

Eve9181 commented Oct 15, 2024

hey, i just checked the controls works fine but the video doesn't get paused when bluetooth headset is disconnected like other players, could you make it so it does that?

@Anthonyy232
Copy link
Contributor Author

Anthonyy232 commented Oct 15, 2024

Probably, that would require registering a broadcast receiver and catching the noisy intent. Not sure if the author would be okay with that

Also as a side note, the app seems to have a delay when pausing and starting (seems to skip frames or something?)

@abdallahmehiz
Copy link
Owner

Probably, that would require registering a broadcast receiver and catching the noisy intent. Not sure if the author would be okay with that

You can go for it.

Also as a side note, the app seems to have a delay when pausing and starting (seems to skip frames or something?)

Yes, mpv does sometimes skip frames when resuming videos.

@Anthonyy232
Copy link
Contributor Author

Ready for review-merge

@abdallahmehiz abdallahmehiz merged commit 16bc363 into abdallahmehiz:main Oct 17, 2024
1 check passed
@Anthonyy232 Anthonyy232 deleted the feature/support-headset-controls branch October 20, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants