Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Large Runners in Build Jobs #142

Merged
merged 13 commits into from
Nov 1, 2023
Merged

Use Large Runners in Build Jobs #142

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
452b335
Try larger runner for build job
pdewilde Sep 28, 2023
0c2ac79
Try larger runner for build job
pdewilde Sep 28, 2023
0eae6a2
3rd time's the charm?
pdewilde Sep 28, 2023
859beb9
3rd time's the charm?
pdewilde Sep 28, 2023
58677b6
Change it back again
pdewilde Sep 28, 2023
7e45406
This may be my most expensive ci job ever
pdewilde Sep 28, 2023
ba719b5
I hate yaml
pdewilde Sep 28, 2023
c91cdbf
I hate yaml
pdewilde Sep 28, 2023
097582c
Merge remote-tracking branch 'origin/main' into pdewilde/bigger-build…
pdewilde Oct 31, 2023
fd46aa5
Merge remote-tracking branch 'origin/main' into pdewilde/bigger-build…
pdewilde Oct 31, 2023
3e22f46
Case sensitivity
pdewilde Oct 31, 2023
126751b
Merge branch 'main' into pdewilde/bigger-build-experiment
pdewilde Oct 31, 2023
0dd45fa
Merge branch 'main' into pdewilde/bigger-build-experiment
pdewilde Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ jobs:

# Build github-metrics-aggregator image and push to artifact registry
build:
runs-on: 'ubuntu-latest'
runs-on:
pdewilde marked this conversation as resolved.
Show resolved Hide resolved
group: 'Beefy' # group with a 4-core and 8-core runner for faster builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdewilde - will it randomly choose one? I created the group because that's the only way to restrict the runners to a specific repo. I was thinking you would use either the 4-core or 8-core machine label directly.

Copy link
Contributor Author

@pdewilde pdewilde Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, I assumed you intended for me to use the group for some reason (maybe so a slow job on the 8-core machine doesn't block all CI-jobs in the beefy group). I'm not sure what the logic is. I did one test and saw it corresponded to the 8-core machine and was hoping it would use the more powerful machine first.

I'll have to take a look and see if it seems to be consistently using the 8-core machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/runner#1665

Looks like there is a long-existing ask but not movement on such a prioritization feature in a year. (That is for Self-Hosted rather than Large runners, but I would imagine the behavior is similar).

Probably best to just slap on the 8-core machine label directly. Probably no need to have a 4-core for now in the Beefy group as most of the other jobs run in pretty similar times.

needs:
- 'lint_and_unit'
permissions:
Expand Down