Reorganize rest_server template with new layout and subfolder convention #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drevell
previously approved these changes
Aug 31, 2023
kevya-google
commented
Aug 31, 2023
t/rest_server/workflows/contents/workflows/deploy-rest-server.yaml
Outdated
Show resolved
Hide resolved
|
Converting back to draft to fix Dockerfile reference from deployments folder in deploy.yaml and getting consensus with @gjonathanhong on folder structure. |
drevell
previously approved these changes
Sep 6, 2023
|
Pending: will try adding input validation. Edit: Added. |
gjonathanhong
approved these changes
Sep 8, 2023
drevell
approved these changes
Sep 11, 2023
chloechien
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ion (#180) Addresses #173, also reformats subdirectory contents in accordance to #166. Template structure: ``` $ tree -all . ├── contents │ ├── go.mod │ ├── go.sum │ ├── main.go │ ├── main_test.go │ └── README.md ├── deployments │ ├── config │ │ └── autopush-rest-server.env │ ├── contents │ │ └── Dockerfile │ ├── README.md │ ├── spec.yaml │ └── workflows │ ├── ci-rest-server.yaml │ └── deploy-rest-server.yaml ├── README.md └── spec.yaml ``` Rendered template structure: ``` $ tree -all . ├── Dockerfile ├── .github │ ├── config │ │ └── autopush-rest-server.env │ └── workflows │ ├── ci-rest-server.yaml │ └── deploy-rest-server.yaml ├── go.mod ├── go.sum ├── main.go ├── main_test.go └── README.md ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #173, also reformats subdirectory contents in accordance to #166.
Template structure:
Rendered template structure: