Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out workflows and Dockerfiles from existing templates #173

Open
kevya-google opened this issue Aug 24, 2023 · 0 comments
Open

Factor out workflows and Dockerfiles from existing templates #173

kevya-google opened this issue Aug 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kevya-google
Copy link
Contributor

kevya-google commented Aug 24, 2023

TL;DR

Currently, rest_server and react_template templates have hard requirements on deployment workflows that have enforced user inputs. The proposed format for abcxyz services suggests factoring these out of the templates into a separate folder with another spec.yaml.

Detailed design

No response

Alternatives considered

No response

Additional information

No response

@kevya-google kevya-google added the enhancement New feature or request label Aug 24, 2023
@kevya-google kevya-google self-assigned this Aug 24, 2023
kevya-google added a commit that referenced this issue Sep 11, 2023
…ion (#180)

Addresses #173, also reformats
subdirectory contents in accordance to
#166.

Template structure:
```
$ tree -all
.
├── contents
│   ├── go.mod
│   ├── go.sum
│   ├── main.go
│   ├── main_test.go
│   └── README.md
├── deployments
│   ├── config
│   │   └── autopush-rest-server.env
│   ├── contents
│   │   └── Dockerfile
│   ├── README.md
│   ├── spec.yaml
│   └── workflows
│       ├── ci-rest-server.yaml
│       └── deploy-rest-server.yaml
├── README.md
└── spec.yaml

```
Rendered template structure:
```
$ tree -all
.
├── Dockerfile
├── .github
│   ├── config
│   │   └── autopush-rest-server.env
│   └── workflows
│       ├── ci-rest-server.yaml
│       └── deploy-rest-server.yaml
├── go.mod
├── go.sum
├── main.go
├── main_test.go
└── README.md
```
chloechien pushed a commit that referenced this issue Sep 12, 2023
…ion (#180)

Addresses #173, also reformats
subdirectory contents in accordance to
#166.

Template structure:
```
$ tree -all
.
├── contents
│   ├── go.mod
│   ├── go.sum
│   ├── main.go
│   ├── main_test.go
│   └── README.md
├── deployments
│   ├── config
│   │   └── autopush-rest-server.env
│   ├── contents
│   │   └── Dockerfile
│   ├── README.md
│   ├── spec.yaml
│   └── workflows
│       ├── ci-rest-server.yaml
│       └── deploy-rest-server.yaml
├── README.md
└── spec.yaml

```
Rendered template structure:
```
$ tree -all
.
├── Dockerfile
├── .github
│   ├── config
│   │   └── autopush-rest-server.env
│   └── workflows
│       ├── ci-rest-server.yaml
│       └── deploy-rest-server.yaml
├── go.mod
├── go.sum
├── main.go
├── main_test.go
└── README.md
```
@kevya-google kevya-google removed their assignment Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant