Feature/json nullwrite #23
Conversation
|
@jdblischak if you're good with this I'd like to squash and merge this one. |
| @@ -70,7 +70,7 @@ createTextFiles <- function(study, directoryname, calcOverlaps = FALSE) { | |||
| dir.create(directoryname, showWarnings = FALSE, recursive = TRUE) | |||
| exportSamples(study, directoryname) | |||
| exportFeatures(study, directoryname) | |||
| exportModels(study, directoryname) | |||
| exportModels(study, directoryname, na="null") | |||
There was a problem hiding this comment.
What is the motivation for only wanting to apply this to the "models" output and not other JSON output like "tests" and "annotations"?
There was a problem hiding this comment.
Companion tools that need to be updated in sequence. This gives us flexibility with output types, which I need (for now) internally. This change won't impact any external users of OmicNavigator. I anticipate na=null to become the default argument for write_json in time.
| @@ -65,7 +65,7 @@ readJson <- function(x, simplifyVector = TRUE, ...) { | |||
| } | |||
|
|
|||
| writeJson <- function(x, file, auto_unbox = TRUE, pretty = TRUE, ...) { | |||
There was a problem hiding this comment.
If you wanted to apply na = "null" to all JSON output files, you could treat it the same as other default arguments like auto_unbox and pretty. Add na = "null" to writeJson() and na = na to jsonlite::write_json()
na="null" passed to write_json for the export of model metadata.