Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect / Disconnect workaround #33

Conversation

splitice
Copy link

@splitice splitice commented Dec 1, 2021

This is a re-submission of PR #32

@rzr
Copy link

rzr commented Dec 1, 2021

Please rebase and double check the appveyor or open an issue to track this bot which can be disabled in next change

@splitice splitice force-pushed the feature/rework-connect-workaround branch from 068b73e to 56c6c89 Compare December 9, 2021 01:43
@splitice splitice force-pushed the feature/rework-connect-workaround branch from 56c6c89 to 6740d14 Compare December 9, 2021 01:44
@rzr
Copy link

rzr commented Dec 9, 2021

@splitice
Copy link
Author

@rzr yes, drop support for node 10 (it's out of support anyway).

FYI I'm working on a complete overhaul of this workaround to resolve memory leaks present in both this version and the original (they leak the l2cap sockets).

My first attempt wasnt successful as it breaks on certain BT implementations (e.g Broadcom) that output reconnections as:

  1. Connect Device 1 (handle 1)
  2. Connect Device 1 (handle 2)
  3. Disconnect Device 1 (handle 1)

A re-engineering of the workaround is required to handle cases like this

@splitice
Copy link
Author

#34

@splitice splitice closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants