Fix MTU for peripheral #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #308 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 24 24
Lines 2902 2902
=======================================
Hits 2664 2664
Misses 238 238
|
|
@rzr tests adjusted |
|
Ok, PR for release comes soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version has two issues regarding MTU:
1.) Mising in types
2.) It is never set because the code only updates mtu if the peripheral.mtu is not falsy (what the default value null always is) so it was never updated.
I decided to remove this check. This could lead to the fact that the MTU could get updated after initially set which could be strange ... but would be the reality. Alternatively the code was just missing a "!" and wanted to only update mtu if "not aloready a value is set" ... no idea.