-
Notifications
You must be signed in to change notification settings - Fork 1
Utilizing Autobot for plank time recording #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c28a679
to
0cf8983
Compare
do not merge, this will require a lot of refactoring before I'm okay with merging. |
I can't help it but I think there's a lot of architecture here that might not be needed. I wonder if our code would become easier to read if we didn't worry too much about "adapter" pattern and so forth. An adapter could be a function, that reads nicely as a function. I feel the goal of the game is to have functions that read as what they're actually doing. |
Yea you've touched on a couple things that have been irking me in this pull request:
My thought process initially was: "What does an adapter do?"
To me, that described an object with behavior. But even from implementing plankbot, these simple tasks are becoming more and more complicated. Take the parsing for example. Parsing slack input? This will include regex. This will include speech pattern recognition. This will also need to know how to adapt the recognized input text and map it to core methods. Rendering the response requires the same amount of research and code vice-versa. And more to this, these are not things we can just confine into functions. These are classes, if not libraries that we will need to import to properly clean out this cruft. I'm not entirely sure if I should halt progress because of these issues, because it will only get worse if I try to half-ass implement them. |
I don't think progress should be halted. We can do both things at the same time. While we add features, we could be refactoring for simplicity. |
[WIP] To get deploying