live-test: disable SortQueryParams addon (airbytehq#44806)

aazam-gh · Aug 27, 2024 · cb6bf8b · cb6bf8b
1 parent 63ab010
commit cb6bf8b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/airbyte-ci/connectors/live-tests/README.md b/airbyte-ci/connectors/live-tests/README.md
@@ -279,6 +279,10 @@ The traffic recorded on the control connector is passed to the target connector
 
 ## Changelog
 
+### 0.18.6
+
+Disable the `SortQueryParams` MITM proxy addon to avoid double URL encoding.
+
 ### 0.18.5
 
 Relax test_oneof_usage criteria for constant value definitions in connector SPEC output.

diff --git a/airbyte-ci/connectors/live-tests/pyproject.toml b/airbyte-ci/connectors/live-tests/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "live-tests"
-version = "0.18.5"
+version = "0.18.6"
 description = "Contains utilities for testing connectors against live data."
 authors = ["Airbyte <[email protected]>"]
 license = "MIT"

diff --git a/airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py b/airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py
@@ -25,4 +25,9 @@ def request(self, flow: http.HTTPFlow) -> None:
             flow.request.url = sorted_url
 
 
-addons = [SortQueryParams()]
+# Disabling the addon.
+# It can alter the request URL when some connector URL are already encoded.
+# See discussion here https://github.com/airbytehq/airbyte-internal-issues/issues/9302#issuecomment-2311854334
+
+# addons = [SortQueryParams()]
+addons = []