-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: link a post directly to its respective GitHub edit page #102
feat: link a post directly to its respective GitHub edit page #102
Conversation
@almndbtr is attempting to deploy a commit to the Bullionix Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bullionix/aavegotchi-wiki/h48tr3juy |
This is really great! The only issue I see is that for localized pages (where lang is other than |
😯 ! Good catch––I'll include that and follow up once that's included. 👍 |
Kudos to @cinnabarhorse for bringing this up in #102 (comment). For localized pages (lanaguages that are not `en`), the Wiki leverages Crowdin rather than directly translating them on GitHub. This change shows the `✏️ Edit this page` button only for pages written in English (checking `router.query.lang` is equal to `en`).
@cinnabarhorse - I've added the language check in 410cedf, following the conditional convention that the contributor container implements. Let me know if you prefer that conditional written differently. I'm wondering––how do users switch languages today? While one could modify the URL and replace it with their preferred language, there doesn't seem to be a button for changing it right from the site. 💭 Let me know if I'm missing something super obvious for language switching! But, if there isn't a way to do that, I can open an issue for tracking as separate work from this PR. ✌️ |
Checking the deploy preview at root, the ✏️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Great job @almndbtr. Feel free to HMU on telegram (@coderdannn) or Discord |
Yes that's been something on the list of to-dos but we haven't gotten around to it yet. If you'd like to open an issue and do some work on it that would be super neat! |
Thanks for merging my pull request, @cinnabarhorse !
Opened #110. I won't hop on it just yet to leave space for the community to jump in, if anyone is interested! ✌️ |
Summary
Closes #103.
Hallo, Aarchiver frens! 👋
After consulting the
Develop this wiki
page, I wanted to contribute a new feature: automatically linking posts directly to their GitHub edit page. 🔗 ✨I know the original request calls for a button, but I opted for a plain link––happy to get any design feedback from the team. 🧑🎨
Consulted resources
Edit on GitHub link
Motion pictures
Desktop (Safari)
Mobile (Chrome, mocking an iPhone X)