fix: merit badge (#2062)

aave · May 7, 2024 · 7dc6525 · 7dc6525 · github-actions · May 7, 2024
1 parent 80c424f
commit 7dc6525
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 16 deletions.
diff --git a/pages/staking.staking.tsx b/pages/staking.staking.tsx
@@ -9,10 +9,6 @@ import dynamic from 'next/dynamic';
 import { useEffect, useState } from 'react';
 import { ConnectWalletPaperStaking } from 'src/components/ConnectWalletPaperStaking';
 import { ContentContainer } from 'src/components/ContentContainer';
-import {
-  MeritIncentivesButton,
-  UserMeritIncentivesButton,
-} from 'src/components/incentives/IncentivesButton';
 import { Link } from 'src/components/primitives/Link';
 import { Warning } from 'src/components/primitives/Warning';
 import StyledToggleButton from 'src/components/StyledToggleButton';
@@ -228,13 +224,6 @@ export default function Staking() {
                   onCooldownAction={() => openStakeCooldown(Stake.gho, 'GHO')}
                   onUnstakeAction={() => openUnstake(Stake.gho, 'GHO')}
                   onStakeRewardClaimAction={() => openStakeRewardsClaim(Stake.gho, 'AAVE')}
-                  headerAction={
-                    stkGhoUserData?.stakeTokenUserBalance !== '0' ? (
-                      <UserMeritIncentivesButton symbol="stkgho" />
-                    ) : (
-                      <MeritIncentivesButton symbol="stkgho" />
-                    )
-                  }
                 />
               </Grid>
 

diff --git a/src/components/incentives/IncentivesButton.tsx b/src/components/incentives/IncentivesButton.tsx
@@ -62,7 +62,7 @@ export const UserMeritIncentivesButton = ({ symbol }: { symbol: 'gho' | 'stkgho'
       setOpen={setOpen}
       open={open}
     >
-      <Content incentives={[incentives]} incentivesNetAPR={+incentives.incentiveAPR} />
+      <Content incentives={[incentives]} incentivesNetAPR={+incentives.incentiveAPR} plus />
     </ContentWithTooltip>
   );
 };
@@ -93,7 +93,7 @@ export const MeritIncentivesButton = ({ symbol }: { symbol: 'gho' | 'stkgho' })
       setOpen={setOpen}
       open={open}
     >
-      <Content incentives={[incentives]} incentivesNetAPR={+incentives.incentiveAPR} />
+      <Content incentives={[incentives]} incentivesNetAPR={+incentives.incentiveAPR} plus />
     </ContentWithTooltip>
   );
 };
@@ -148,10 +148,12 @@ const Content = ({
   incentives,
   incentivesNetAPR,
   displayBlank,
+  plus,
 }: {
   incentives: ReserveIncentiveResponse[];
   incentivesNetAPR: number | 'Infinity';
   displayBlank?: boolean;
+  plus?: boolean;
 }) => {
   const [open, setOpen] = useState(false);
   const trackEvent = useRootStore((store) => store.trackEvent);
@@ -226,8 +228,9 @@ const Content = ({
         setOpen(!open);
       }}
     >
-      <Box sx={{ mr: 2 }}>{incentivesButtonValue()}</Box>
-
+      <Box sx={{ mr: 2 }}>
+        {plus ? '+' : ''} {incentivesButtonValue()}
+      </Box>
       <Box sx={{ display: 'inline-flex' }}>
         <>
           {incentives.length < 5 ? (

diff --git a/src/modules/staking/StakingPanel.tsx b/src/modules/staking/StakingPanel.tsx
@@ -17,6 +17,10 @@ import {
 import { BigNumber } from 'ethers';
 import { formatEther, formatUnits } from 'ethers/lib/utils';
 import React from 'react';
+import {
+  MeritIncentivesButton,
+  UserMeritIncentivesButton,
+} from 'src/components/incentives/IncentivesButton';
 import { DarkTooltip } from 'src/components/infoTooltips/DarkTooltip';
 import { FormattedNumber } from 'src/components/primitives/FormattedNumber';
 import { Link } from 'src/components/primitives/Link';
@@ -320,7 +324,21 @@ export const StakingPanel: React.FC<StakingPanelProps> = ({
               </TextWithTooltip>
             )}
           </Stack>
-          <FormattedNumber value={stakeData.stakeApyFormatted} percent variant="secondary14" />
+          <Stack direction="row" alignItems="center">
+            <FormattedNumber
+              sx={{ mr: 2 }}
+              value={stakeData.stakeApyFormatted}
+              percent
+              variant="secondary14"
+            />
+            {stakedToken === 'GHO' ? (
+              stakeUserData.stakeTokenUserBalance !== '0' ? (
+                <UserMeritIncentivesButton symbol="stkgho" />
+              ) : (
+                <MeritIncentivesButton symbol="stkgho" />
+              )
+            ) : null}
+          </Stack>
         </Box>
         <Box
           sx={{