forked from bgd-labs/aave-proposals-v3
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHO CCIP 1.5 Maintenance Upgrade #15
Closed
Closed
Changes from 14 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
faf2023
feat: install aave-ccip at latest commit on aave/ccip#18
DhairyaSethi 488d846
chore: upd remappings, lib/aave-helpers, .assets
DhairyaSethi 1927921
new: add proposal for eth & arb
DhairyaSethi 9cc5769
fix: arb test supply locked invariant
DhairyaSethi 0ed5033
Merge branch 'main' into new/ccip_1_5_maintenance
DhairyaSethi 58e177d
fix: rename, add discussion link
DhairyaSethi a3310b8
upd: aave-ccip module
DhairyaSethi a78018d
feat: add proxy pool deployments
DhairyaSethi f962303
feat: add e2e tests
DhairyaSethi 38a1159
chore: fix license, explicit senders for expectEmit
DhairyaSethi f199681
ci: override rpc url in secrets
DhairyaSethi 7b2376b
test: proxy pool can off ramp
DhairyaSethi d4d438e
chore: reorder deps
DhairyaSethi fc6a51c
nit: utilize existing ierc20 import, style guide, use arb assets for …
DhairyaSethi f64be60
feat: add rate limit, use gho fascilitator for tests
DhairyaSethi af02c9e
feat: set in bound rate limit as well
DhairyaSethi 9507080
chore: cleanup
DhairyaSethi 1f15974
test: check proxy initialized version
DhairyaSethi 3954cb7
chore: inBetween => inFlight"
DhairyaSethi 9abb6d3
chore: test name consistency
DhairyaSethi ced148d
test: dynamically fetch dest gas amt
DhairyaSethi b1da849
test: execMsg post migration using legacy off ramp
DhairyaSethi bf4f3e5
test: ccip steward can disable rate limit
DhairyaSethi a525136
chore: cleanup
DhairyaSethi be370f6
doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity
DhairyaSethi 8f151e2
test: ownership transfer after migration
DhairyaSethi 00d8306
chore: rm _readRiskAdmin, fix config
DhairyaSethi 870aed7
Merge branch 'main' into new/ccip_1_5_maintenance
DhairyaSethi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
[submodule "lib/aave-helpers"] | ||
path = lib/aave-helpers | ||
url = https://github.com/bgd-labs/aave-helpers | ||
[submodule "lib/aave-ccip"] | ||
path = lib/aave-ccip | ||
url = https://github.com/aave/ccip |
7 changes: 7 additions & 0 deletions
7
...IP150Upgrade_20241021_before_AaveV3Arbitrum_GHOCCIP150Upgrade_20241021_after.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
## Emodes changes | ||
|
||
## Raw diff | ||
|
||
```json | ||
{} | ||
``` |
7 changes: 7 additions & 0 deletions
7
...IP150Upgrade_20241021_before_AaveV3Ethereum_GHOCCIP150Upgrade_20241021_after.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
## Emodes changes | ||
|
||
## Raw diff | ||
|
||
```json | ||
{} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity ^0.8.0; | ||
|
||
import {TransparentUpgradeableProxy} from 'solidity-utils/contracts/transparent-proxy/TransparentUpgradeableProxy.sol'; | ||
DhairyaSethi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import {ProxyAdmin} from 'solidity-utils/contracts/transparent-proxy/ProxyAdmin.sol'; | ||
import {IProposalGenericExecutor} from 'aave-helpers/src/interfaces/IProposalGenericExecutor.sol'; | ||
import {MiscArbitrum} from 'aave-address-book/MiscArbitrum.sol'; | ||
import {UpgradeableBurnMintTokenPool} from 'aave-ccip/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol'; | ||
|
||
/** | ||
* @title GHO CCIP 1.50 Upgrade | ||
* @author Aave Labs | ||
* - Discussion: https://governance.aave.com/t/bgd-technical-maintenance-proposals/15274/51 | ||
*/ | ||
contract AaveV3Arbitrum_GHOCCIP150Upgrade_20241021 is IProposalGenericExecutor { | ||
address public constant GHO_CCIP_PROXY_POOL = 0x26329558f08cbb40d6a4CCA0E0C67b29D64A8c50; | ||
|
||
function execute() external { | ||
UpgradeableBurnMintTokenPool tokenPoolProxy = UpgradeableBurnMintTokenPool( | ||
MiscArbitrum.GHO_CCIP_TOKEN_POOL | ||
); | ||
|
||
// Deploy new tokenPool implementation, retain existing immutable configuration | ||
address tokenPoolImpl = address( | ||
new UpgradeableBurnMintTokenPool( | ||
address(tokenPoolProxy.getToken()), | ||
tokenPoolProxy.getArmProxy(), | ||
tokenPoolProxy.getAllowListEnabled() | ||
) | ||
); | ||
|
||
ProxyAdmin(MiscArbitrum.PROXY_ADMIN).upgrade( | ||
TransparentUpgradeableProxy(payable(address(tokenPoolProxy))), | ||
tokenPoolImpl | ||
); | ||
|
||
// Update proxyPool address | ||
tokenPoolProxy.setProxyPool(GHO_CCIP_PROXY_POOL); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update with final commit