Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stationary Ball option in GUI #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demifang
Copy link

Aatish, after working on p5 to make sure it ran OK, I just copy/pasted my new p5 code into this "Edit file" field-- is that how it works? Hope you can see the changes I made. If not, I introduced "isBallMoving" boolean variable and made a Stationary Ball option in the drop-down menu for interactions.

The one thing I couldn't figure out is in line 212-- currently, when you select Stationary Ball, the new stationary ball takes on the position of the Moving Ball before it stopped. I think it'd be better to have the position be reset to the center, but I wasn't sure how to go about doing that.

Alternatively, maybe it'd be nicer to have a checkbox for "moving" when the "Ball" option is selected from the dropdown menu-- in this scenario, I wouldn't mind the stationary ball taking on the old position. However, I wasn't sure how to code the GUI so that the checkbox would only be activated when a certain dropdown option is selected. Let me know what you think!

Aatish, after working on p5 to make sure it ran OK, I just copy/pasted my new p5 code into this "Edit file" field-- is that how it works? Hope you can see the changes I made. If not, I introduced "isBallMoving" boolean variable and made a Stationary Ball option in the drop-down menu for interactions.

The one thing I couldn't figure out is in line 212-- currently, when you select Stationary Ball, the new stationary ball takes on the position of the Moving Ball before it stopped. I think it'd be better to have the position be reset to the center, but I wasn't sure how to go about doing that.

Alternatively, maybe it'd be nicer to have a checkbox for "moving" when the "Ball" option is selected from the dropdown menu-- in this scenario, I wouldn't mind the stationary ball taking on the old position. However, I wasn't sure how to code the GUI so that the checkbox would only be activated when a certain dropdown option is selected. Let me know what you think!
@aatishb
Copy link
Owner

aatishb commented May 24, 2016

Hi Demi, thanks for making the pull request! The changes make sense to me. However, when I test it out I’m getting a very slight visual glitch (in the moving ball, a few particles of the cloth tend to ‘jump around’ just a little.) I’ll try to get to the bottom of this.

@aatishb
Copy link
Owner

aatishb commented May 24, 2016

Could you check to see if you see the same glitch as well? It's an effect where a few particles seem to be pushed slightly away from the moving ball. It's weird because as far as I can tell, nothing should be affected for the moving ball.

@demifang
Copy link
Author

Right, Aatish I see this bug for the stationary ball as well. Actually I'm
trying the latest web version and I think I see the same jumpiness there--
could it be unrelated to the stationary ball addition?
Another thing I just noticed in my stationary ball addition is that for the
stationary ball, I'm not sure the friction is working-- I turned up the
friction to 1 and the cloth was still sliding off the ball. Did you get the
same thing by any chance?

Demi Fang
Department of Civil & Environmental Engineering
Certificate Program in Musical Performance
Princeton University | Class of 2017
[email protected]

On Mon, May 23, 2016 at 9:08 PM, aatishb [email protected] wrote:

Could you check to see if you see the same glitch as well? It's an effect
where a few particles seem to be pushed slightly away from the moving ball.
It's weird because as far as I can tell, nothing should be affected for the
moving ball.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants