removed redundant test and fixed typo in id

aasimsyed · Jul 5, 2024 · 3ebb07d · 3ebb07d
1 parent 6efcc68
commit 3ebb07d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/frontend/components/header/HeaderWebsite.vue b/frontend/components/header/HeaderWebsite.vue
@@ -10,7 +10,7 @@
     }"
   >
     <!-- MARK: Mobile Header -->
-    <div v-if="!aboveMediumBP" id="#mobile-header" class="flex px-4 py-3">
+    <div v-if="!aboveMediumBP" id="mobile-header" class="flex px-4 py-3">
       <div class="z-0 mx-auto">
         <div
           class="absolute left-0 top-0 z-0 flex h-full w-full items-center justify-center"

diff --git a/frontend/tests/specs/landing-page.spec.ts b/frontend/tests/specs/landing-page.spec.ts
@@ -14,23 +14,12 @@ test.describe("Landing Page", () => {
   /* HEADER TESTS */
   /* *********************************************************** */
 
-  // Test that Header is visible if the viewport is large enough.
-  test("Header should be visible", async ({ landingPage }) => {
-    if (!(await landingPage.isMobile())) {
-      const { desktopHeader } = landingPage.header;
-      await expect(desktopHeader).toBeVisible();
-    } else {
-      const { mobileHeader } = landingPage.header;
-      await expect(mobileHeader).toBeVisible();
-    }
-  });
-
   // Test that the Header is visible on both mobile and desktop.
   test("Header visibility on mobile and desktop", async ({ landingPage }) => {
-    const headerVisibility = (await landingPage.isMobile())
+    const header = (await landingPage.isMobile())
       ? landingPage.header.mobileHeader
       : landingPage.header.desktopHeader;
-    await expect(headerVisibility).toBeVisible();
+    await expect(header).toBeVisible();
   });
 
   // Test that the Roadmap button is visible and clickable only on Desktop.