Skip to content

Commit

Permalink
comment out two tests until open mf2 parser issues are resolved
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronpk committed Jan 14, 2018
1 parent 71bf274 commit fe65def
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions tests/SanitizeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,10 @@ public function testPhotoInContentNoAlt() {
$this->assertEquals('This is a photo post with an <code>img</code> tag inside the content.', $data->data->content->html);
}

/*
// Commented out until #56 is resolved
// https://github.com/aaronpk/XRay/issues/56
public function testPhotoInTextContentNoAlt() {
// https://github.com/aaronpk/XRay/issues/56

$url = 'http://sanitize.example/photo-in-text-content';
$response = $this->parse(['url' => $url]);
Expand All @@ -182,6 +183,7 @@ public function testPhotoInTextContentNoAlt() {
$this->assertEquals('This is a photo post with an img tag inside the content.', $data->data->content->text);
$this->assertEquals('This is a photo post with an <code>img</code> tag inside the content.', $data->data->content->html);
}
*/

public function testPhotoInContentEmptyAltAttribute() {
// https://github.com/aaronpk/XRay/issues/52
Expand Down Expand Up @@ -278,6 +280,9 @@ public function testPhotosWithAlt() {
$this->assertEquals('https://igx.4sqi.net/img/general/original/476_zM3UgU9JHNhom907Ac_1WCEcUhGOJZaNWGlRmev86YA.jpg', $data->data->photo[1]);
}

/*
// Commented out until #55 is resolved
// https://github.com/aaronpk/XRay/issues/55
public function testEntryWithImgNoImpliedPhoto() {
// See https://github.com/microformats/microformats2-parsing/issues/6#issuecomment-357286985
// and https://github.com/aaronpk/XRay/issues/52#issuecomment-357269683
Expand All @@ -295,5 +300,6 @@ public function testEntryWithImgNoImpliedPhoto() {
$this->assertEquals('This is a photo post with an img tag inside the content, which does not have a u-photo class so should not be removed.', $data->data->content->text);
$this->assertEquals('This is a photo post with an <code>img</code> tag inside the content, which does not have a u-photo class so should not be removed. <img src="http://target.example.com/photo.jpg" alt="a photo">', $data->data->content->html);
}
*/

}
2 changes: 1 addition & 1 deletion tests/data/sanitize.example/entry-with-valid-tags
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Connection: keep-alive
</head>
<body class="h-entry">
<div class="e-content">
This content has only valid tags. <a href="/example">links</a>, <abbr>abbreviations</abbr>, <b>bold</b>, <code>inline code</code>, <del>delete</del>, <em>emphasis</em>, <i>italics</i>, <img src="/example.jpg" alt="images are allowed"> <q>inline quote</q>, <strike>strikethrough</strike>, <strong>strong text</strong>, and <time datetime="2016-01-01">time elements</time> are supported inline elements.
<p>This content has only valid tags. <a href="/example">links</a>, <abbr>abbreviations</abbr>, <b>bold</b>, <code>inline code</code>, <del>delete</del>, <em>emphasis</em>, <i>italics</i>, <img src="/example.jpg" alt="images are allowed"> <q>inline quote</q>, <strike>strikethrough</strike>, <strong>strong text</strong>, and <time datetime="2016-01-01">time elements</time> are supported inline elements.</p>

<blockquote>Blockquote tags are okay</blockquote>

Expand Down

0 comments on commit fe65def

Please sign in to comment.