Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub banner #3

Open
wants to merge 1 commit into
base: aaroads
Choose a base branch
from
Open

Remove GitHub banner #3

wants to merge 1 commit into from

Conversation

Scott5114
Copy link

No description provided.

Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay; I missed the notification about this PR somehow. I agree that the GitHub banner is too in-your-face, especially on what’s already a fork. However, there should ideally be some kind of link back to one of the repositories, either of OSM Americana or the AARoads fork, purely as a courtesy. This will help users figure out how to contribute and make sre they aren’t left with the impression that it’s OpenMapTiles that produced this style. (OMT’s repository hosts a different style that mimics openstreetmap-carto.)

To keep things simple, I recommend adding OSM Americana as ordinary attribution, just without the copyright symbol, since the project is proudly in the public domain. Add a line like the following to both src/configs/config.aws.js and src/configs/config.localhost.js, substituting the HTML link text and URL with Americana’s:

const ATTRIBUTION_TEXT =
'<a href="https://www.maptiler.com/copyright/" target="_blank">&copy; MapTiler</a>';

@1ec5
Copy link
Member

1ec5 commented Oct 8, 2023

I just synchronized this repository with the latest upstream. This pulled in osm-americana#945, which implements a bare_map.html that contains no controls. I think it’s overcorrecting by omitting any attribution, but you might find it to be a better starting point for embedding purposes than index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants