Use system libuv when conf-libuv is available #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conf-libuv is now an optional dependency, and if installed then by default, the system libuv will be used instead of the vendored build. This provides a more convenient way to control how luv is built. This can still be overridden by setting: LUV_USE_SYSTEM_LIBUV=no
|
It would be better to move the jbuild plugin stuff to use dune-configurator instead so the intermediate environment variable can be avoided, however, moving to that would require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conf-libuv is now an optional dependency, and if installed then the system libuv will be used instead of the vendored build, by default.
This provides a more convenient way to control how luv is built. This can still be overridden by setting:
LUV_USE_SYSTEM_LIBUV=no.The bash commands and configure scripts required to build luv from source are not very portable, and as seen in #162, they don't work properly on Windows without additional setup. This patch useful for projects that run on windows, as they can simply add
conf-libuvto their dependencies to use the system version, without needing manual intervention every time dependencies are installed/updated.