Avoid carriage return bug when configuring libuv on Windows #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carriage returns will appear when running the command on windows, which means that the configure script cannot function correctly because it relies on the host value to locate certain executables (such as `ar`).
I've changed it to the built-in dune variable |
tobil4sk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carriage returns will appear when running the command on windows, which means that the configure script cannot function correctly because it relies on the host value to locate certain executables (such as
ar).This is actually the cause of #162. Fixing this doesn't completely solve (local) windows builds, as dune doesn't currently run the correct bash executable, see: ocaml/dune#11438. This can be worked around by adding the output of
$(opam exec -- cygpath -w /bin)to PATH.Alternatively, this could all be replaced with
ocamlc -config-var hostwhich is cleaner, but that would increase the required ocaml version to 4.08. What would your preference be? @aantron