Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

370 Pylint alerts corrections as part of intervention experiment #371

Merged
merged 17 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added __init__.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct again.
It was created and committed by mistake.
I deleted it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted both the correct file and one extra file that is needed. __init__.py at the repository root was not needed, but yledl/__init__.py is required (it specifies which functions are exported by the yledl module).

You can restore the correct state by reverting the commit 5603556

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that.
I reverted the commit.

Empty file.
3 changes: 2 additions & 1 deletion tests/unit/test_downloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
from yledl.backends import BaseDownloader, FailingBackend
from yledl.downloader import YleDlDownloader
from yledl.errors import TransientDownloadError
from yledl.extractors import Clip, FailedClip, StreamFlavor
from yledl.data_extractors import Clip
from yledl.extractors import FailedClip, StreamFlavor
from yledl.titleformatter import TitleFormatter


Expand Down
Loading