-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
370 Pylint alerts corrections as part of intervention experiment #371
Merged
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6d4053f
yledl\downloader.py comparison-of-constants
evidencebp 0cc7e7f
yledl\yledl.py too-many-statements in main
evidencebp e223aef
yledl\yledl.py too-many-statements
evidencebp dd81d24
more functions extraction
evidencebp 8d4ddc2
Move the rest of the arguments into _add_io_group_arguments
evidencebp 59a964c
Create data_extractors and move Clip - WIP
evidencebp 4bff9d6
Import Clip from new location - WIP
evidencebp 2fbbf4b
Move also AreenaApiProgramInfo, EpisodeMetadata
evidencebp 84dc797
More move fitting
evidencebp 028671d
Moved Areena classes to areena_extractors
evidencebp 5b32141
Revert "Moved Areena classes to areena_extractors"
evidencebp 76f3e6a
Revert "More move fitting"
evidencebp 7c58741
Revert "Move also AreenaApiProgramInfo, EpisodeMetadata"
evidencebp f8f2ab5
Revert "Import Clip from new location - WIP"
evidencebp 45b5cd9
Revert "Create data_extractors and move Clip - WIP"
evidencebp 5603556
Delete __init__.py
evidencebp 77aaecb
Revert "Delete __init__.py"
evidencebp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct again.
It was created and committed by mistake.
I deleted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You deleted both the correct file and one extra file that is needed.
__init__.py
at the repository root was not needed, butyledl/__init__.py
is required (it specifies which functions are exported by the yledl module).You can restore the correct state by reverting the commit 5603556
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that.
I reverted the commit.