Update outdated CI actions #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `upload_artifact`/`download_artifact` actions were using the outdated NodeJS v16 runtime in version v3, which we depended on. This commit bumps them to the latest version. Also, the lakeFS sidecar container version needed for the docs builds has been made consistent with the PR workflow (which was using the latest Docker image by default). See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 5 5
Lines 388 388
Branches 72 72
=======================================
Hits 366 366
Misses 13 13
Partials 9 9 ☔ View full report in Codecov by Sentry. |
maxmynter
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload_artifact/download_artifactactions were using the outdated NodeJS v16 runtime in version v3, which we depended on.This commit bumps them to the latest version, addressing the deprecation warnings raised by the release workflow.
Also, the lakeFS sidecar container version needed for the docs builds has been made consistent with the PR workflow (which was using the latest Docker image by default).
See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-
node-20/
Note to reviewer: Sorry for the whitespace re-formatting - we should probably adopt common YAML formatting settings going forward ;)