Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword Python environment installation guide #152

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

nicholasjng
Copy link
Collaborator

The previous iteration tried to give instructions for a hermetic virtual environment used via ipykernel, but never gave instructions on how to do so.

This change removes the recommendation to register the virtual environment as a hermetic kernel, and instead recommends to install all necessary dependencies into the single environment, including Jupyter Notebook itself.

Some minor style changes were made to the rest of the setup instructions, including capitalization of Docker everywhere and fixing some incorrect grammar.

@nicholasjng
Copy link
Collaborator Author

Still left TODO: Figure out how to correctly render the lists at the start of the notebook in mkdocs/mike.

Also I would like to discuss who is responsible for bootstrapping the requirements (esp. in CI) - do we substitute the install instruction with a !pip install --upgrade ... executable cell? This is cross platform AND works for both single and hermetic environments, but produces output which (as of now) is included in the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ba1b4b) 87.66% compared to head (42522b3) 87.66%.

❗ Current head 42522b3 differs from pull request most recent head 326d25a. Consider uploading reports for the commit 326d25a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files           7        7           
  Lines         446      446           
  Branches       62       62           
=======================================
  Hits          391      391           
  Misses         33       33           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nicholasjng and others added 5 commits November 20, 2023 11:46
The previous iteration tried to give instructions for a hermetic virtual
environment used via ipykernel, but never gave instructions on how to do
so.

This change removes the recommendation to register the virtual
environment as a hermetic kernel, and instead recommends to install all
necessary dependencies into the single environment, including Jupyter
Notebook itself.

Some minor style changes were made to the rest of the setup instructions,
including capitalization of Docker everywhere and fixing some incorrect
grammar.
…ssifier

Also update all filenames and commit messages to reflect the change in
tutorial scope.

This cuts down docs execution time to under 10 seconds, so it is better
for frequent documentation rebuilds while developing.

Additionally, we inline the requirements installation into the notebook,
since that is the right place for them. The prerequisites part and
virtual environment guide is removed, since users are expected to know it.
@nicholasjng nicholasjng force-pushed the notebook-install-change branch from 35a2b66 to 627c022 Compare November 20, 2023 11:53
@nicholasjng nicholasjng force-pushed the notebook-install-change branch from 42522b3 to 326d25a Compare November 20, 2023 13:11
@nicholasjng
Copy link
Collaborator Author

To finally address @Maciej818's comments (and to see why my responses are correct): The lakefs-spec version that is used in the notebook is the development version installed from the PR branch / commit, which carries all the latest changes - that is why the notebook is able to run to completion in CI.

@nicholasjng nicholasjng linked an issue Nov 20, 2023 that may be closed by this pull request
2 tasks
@nicholasjng
Copy link
Collaborator Author

Restructuring of the put events to be done in a follow-up.

@nicholasjng nicholasjng merged commit 5637b27 into main Nov 20, 2023
@nicholasjng nicholasjng deleted the notebook-install-change branch November 20, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs misrendering on development
3 participants