Attempt to cover more cases

aaclause · Nov 5, 2020 · 488f87a · 488f87a
1 parent c049ccc
commit 488f87a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/addon/globalPlugins/brailleExtender/__init__.py b/addon/globalPlugins/brailleExtender/__init__.py
@@ -246,9 +246,12 @@ def event_gainFocus(self, obj, nextHandler):
 
 	def event_nameChange(self, obj, nextHandler):
 		if config.conf["brailleExtender"]["advanced"]["refreshForegroundObjNameChange"]:
-			obj = api.getForegroundObject()
-			braille.handler.handleUpdate(obj)
-			vision.handler.handleUpdate(obj, property="name")
+			fg = api.getForegroundObject()
+			visibleRegions = list(braille.handler.mainBuffer.visibleRegions)
+			if len(visibleRegions) > 1 and visibleRegions[0].obj is not api.getFocusObject() and visibleRegions[0].obj is not fg:
+				visibleRegions[0].obj = fg
+			braille.handler.handleUpdate(fg)
+			vision.handler.handleUpdate(fg, property="name")
 		nextHandler()
 
 	def createMenu(self):

diff --git a/addon/globalPlugins/brailleExtender/settings.py b/addon/globalPlugins/brailleExtender/settings.py
@@ -734,7 +734,7 @@ class AdvancedDlg(gui.settingsDialogs.SettingsPanel):
 
 	def makeSettings(self, settingsSizer):
 		sHelper = gui.guiHelper.BoxSizerHelper(self, sizer=settingsSizer)
-		self.refreshForegroundObjNameChange = sHelper.addItem(wx.CheckBox(self, label="event_nameChange: " + _("refresh braille region related to &foreground object")))
+		self.refreshForegroundObjNameChange = sHelper.addItem(wx.CheckBox(self, label="event_nameChange: " + _("force the refresh of braille region related to &foreground object")))
 		self.refreshForegroundObjNameChange.SetValue(config.conf["brailleExtender"]["advanced"]["refreshForegroundObjNameChange"])
 
 	def onSave(self):