Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates react and ts versions #436

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Updates react and ts versions #436

merged 2 commits into from
Aug 6, 2022

Conversation

Qwebeck
Copy link
Member

@Qwebeck Qwebeck commented Jul 21, 2022

Fixes #435

Comment on lines -55 to -57
function handleCivilTimeChange(
const handleCivilTimeChange = useCallback((
event: React.ChangeEvent<HTMLTextAreaElement | HTMLInputElement>
): void {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but there started to appear this warning
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md

I thought, that it is quite useful and decided to fix it instead of disabling.

Copy link
Contributor

@net-runner net-runner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. One small thing we should stick to using one package manager. Ive picked yarn.

Green and lets go.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Qwebeck Qwebeck enabled auto-merge (squash) August 6, 2022 21:52
@Qwebeck Qwebeck disabled auto-merge August 6, 2022 21:52
@Qwebeck Qwebeck merged commit 0cf04c5 into next Aug 6, 2022
@Qwebeck Qwebeck deleted the deps-fixes branch August 6, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants