Cli #15
Open
Cli #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # bayesian_cnn_prometheus/preprocessing/data_splitter.py
Qwebeck
reviewed
Dec 6, 2021
Comment on lines
+35
to
+41
| config = get_mask_analyser_config() if len(sys.argv) < 4 else MaskAnalysisConfig('', '', '') | ||
|
|
||
| model_name = get_arg(1, config.model_name) | ||
| lesion_masks_path = get_arg(2, config.lesion_masks_path) | ||
| variance_masks_path = get_arg(3, config.variance_masks_path) | ||
|
|
||
| analise(model_name, lesion_masks_path, variance_masks_path) |
There was a problem hiding this comment.
Z ciekawości: czemu nie użyłeś tutaj click'a?
| default=Paths.RESULTS_PATH, | ||
| type=click.STRING, | ||
| help='Path to the variance masks') | ||
| @click.option('--model-name') |
There was a problem hiding this comment.
Może dać też krótką flagę -m?
A na maskach dać -l (od lesions)`
| @@ -24,18 +24,22 @@ class Paths: | |||
| MASKS_DIR = 'LESIONS' | |||
| MASKS_PATH = DATA_DIR / MASKS_DIR | |||
| MASK_FILE_PATTERN = 'MASK_{}.{}' | |||
| MASK_FILE_PATTERN_WITH_DIR = Path(MASKS_DIR) / MASK_FILE_PATTERN | |||
There was a problem hiding this comment.
Czemu chcesz zamienić MASK_FILE_PATTERN_PATH na MASK_FILE_PATTERN_WITH_DIR?
Mi się wydaje, że takie mnożenie zmiennych jest trochę niewygodne, bo potem będzie trudno się zoorientować co do czego się odnosi.
| assert_fields_have_values(app_config.get('mask_analysis', {}), [ | ||
| field.name for field in fields(MaskAnalysisConfig)]) | ||
| config = MaskAnalysisConfig(**app_config['mask_analysis']) | ||
| def analise(model_name: str, variance_masks_path: str, lesion_masks_path: str): |
There was a problem hiding this comment.
Literówka, analyse/analyze
| mask_analyzer = MasksAnalyzer( | ||
| config.model_name, config.lesion_masks_path, config.variance_masks_path) | ||
|
|
||
| def analise_from_config(config: MaskAnalysisConfig): |
There was a problem hiding this comment.
Jak wyżej, literówka
Comment on lines
+23
to
+27
| mask_analyzer = MasksAnalyzer(config.model_name, config.lesion_masks_path, config.variance_masks_path) | ||
| mask_analyzer.perform_analysis(save_to_json=True) | ||
|
|
||
|
|
||
| def get_mask_analyser_config(): |
There was a problem hiding this comment.
Moim zdaniem powinniśmy ujednolicić tutaj konwencję - albo MaskAnalyzer i get_mask_analyzer_config, albo analogicznie pisownia z 's'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jako że nigdy nic nie robiłem na prometeuszu prosiłbym o sprawdzenie, albo pokazanie mi jak to mogę zrobić :)
Kod zrobiłem tak, aby w dalszym ciągu była możliwość uruchomienia mainów osobno, a nie z konsoli.