Offline tests #38
Open
Offline tests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwebeck
commented
Sep 25, 2022
| @@ -6,6 +6,8 @@ | |||
| from local_search.problems.graph_coloring_problem.models.edge import Edge | |||
| from local_search.problems.graph_coloring_problem.state import GraphColoringState | |||
|
|
|||
| # Do we want to have TODOs on this class. It not teaches students nothing about algorithms, only makes them familiar with the problem? | |||
There was a problem hiding this comment.
Zastanawiam się nad tym, czy chcemy żeby studenci implementowali Goal?
Według mnie to by było fajne gdyby oprócz tego TODO było jeszcze kilka dotyczących architektury solvery, bo wtedy to by pozwoliło:
- lepiej zrozumieć jak działa nasz solver
- pokazało by im jak można podchodzić do implementacji rzeczywistych solverów.
Natomiast teraz większość TODO dotyczy algorytmów i to jak na mnie jest trochę zbędne.
| @@ -0,0 +1,109 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Przeniosłem ten problem z tego repozytorium
| from tests.sum_problem import SumProblem, SumProblemGoal, Maximize, Minimize, SumProblemState | ||
|
|
||
|
|
||
| # TODO: should be here? |
There was a problem hiding this comment.
Przeniosłem testy z tego repo.
Nie widzę żeby w kodzie były jakiekolwiek metody dotyczące hill climbingu, ale myślę, że można by było je dodać skoro testy już są.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36
Przeniosłem zmieniajac wejściowe dane i usuwając część dot. Bobota z tego repozytorium