Fix version 1.6.2 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e1da8c. Signed-off-by: Isaac Halvorson <[email protected]>
a7ex
requested changes
Jun 16, 2024
There was a problem hiding this comment.
I fixed the issue from 1.6.2 in 1.6.4 now.
Please have a look at my version 1.6.4 at https://github.com/a7ex/xcresultparser
Thanks for the help meanwhile. I didn't quite revert everything as in your fix. There were two problems: 1.) Failing unit tests due to a mistake on my side. 2.) Failing build due to SwiftLint, which I removed again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some tests were failing on version 1.6.2. I reverted any changes in the most recent commit to
mainthat were not directly related to fixing the DTD file. Tests seem to pass now, so maybe this will fix the new problems caused by 1.6.2.