refactored from() method for MemoryOp array impl #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The following RV32IM ops are not matched to any memory operation since the original code did not match them: |
moodlezoup
reviewed
Feb 18, 2025
Comment on lines
+199
to
+204
| RV32IM::JAL => [ | ||
| MemoryOp::noop_read(), | ||
| MemoryOp::noop_read(), | ||
| rd_write(), | ||
| MemoryOp::noop_read(), | ||
| ], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
from(val: &RVTraceRow)method. Instead of matching an instruction type to an array of memory operations, the method now matches all of the RV32IM instructions to a specific memory operation, including theRV32IM::ECALLinstruction.