Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-gcp-storage #572

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

e2e-gcp-storage #572

wants to merge 2 commits into from
+0 −0

Conversation

Carlos-Oliver-O
Copy link
Collaborator

@Carlos-Oliver-O Carlos-Oliver-O commented Feb 14, 2025 •
edited
Loading

PULL REQUEST

Si has llegado hasta aquí es que ya estás preparado para hacer tu PR:

Antes de continuar... asegúrate de lo siguiente:

Pon una x en las cajas siguientes para asegurar que has seguido el proceso:

  • He probado mi código y funciona en local
  • He validado que mi código es correcto a niveles de formato
  • Me he asegurado de no haber comiteado o filtrado ninguna contraseña
  • No he copiado mi código porque soy una persona muy responsable :-)

Opcional:

Pega una meme que exprese como te has sentido durante tu trabajo, no es obligatorio pero es divertido :-P

a10pepo
a10pepo requested changes Feb 15, 2025
View reviewed changes
Copy link
Owner

@a10pepo a10pepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La carpeta se tiene qeu llamar GCP_ALMACENAMIENTO

@Carlos-Oliver-O
Copy link
Collaborator Author

Carpeta corregida

mimove
mimove approved these changes Feb 23, 2025
View reviewed changes
Copy link
Collaborator

@mimove mimove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen trabajo Carlos. He visto que lo has completado entero el ejercicio y has podido crear algunas visualizaciones en Metabase. Para las clases que darás repetidas en fin de semana estaría bien que trabajaras en alguna de las propuestas alternativas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a10pepo a10pepo a10pepo requested changes

@mimove mimove mimove approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
entregable GCP-Almacenamiento
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Carlos-Oliver-O @a10pepo @mimove