Skip to content

Commit

Permalink
Multi-page layout xitanggg#60
Browse files Browse the repository at this point in the history
  • Loading branch information
a-sync committed Sep 3, 2024
1 parent 8bab59d commit 8a211d5
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/app/components/Resume/ResumePDF/ResumePDFCustom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const ResumePDFCustom = ({
const { descriptions } = custom;

return (
<ResumePDFSection themeColor={themeColor} heading={heading}>
<ResumePDFSection themeColor={themeColor} heading={heading} wrap={false}>
<View style={{ ...styles.flexCol }}>
<ResumePDFBulletList
items={descriptions}
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/Resume/ResumePDF/ResumePDFEducation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const ResumePDFEducation = ({
showBulletPoints: boolean;
}) => {
return (
<ResumePDFSection themeColor={themeColor} heading={heading}>
<ResumePDFSection themeColor={themeColor} heading={heading} wrap={false}>
{educations.map(
({ school, degree, date, gpa, descriptions = [] }, idx) => {
// Hide school name if it is the same as the previous school
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/Resume/ResumePDF/ResumePDFProject.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const ResumePDFProject = ({
themeColor: string;
}) => {
return (
<ResumePDFSection themeColor={themeColor} heading={heading}>
<ResumePDFSection themeColor={themeColor} heading={heading} wrap={false}>
{projects.map(({ project, date, descriptions }, idx) => (
<View key={idx}>
<View
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/Resume/ResumePDF/ResumePDFSkills.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const ResumePDFSkills = ({
];

return (
<ResumePDFSection themeColor={themeColor} heading={heading}>
<ResumePDFSection themeColor={themeColor} heading={heading} wrap={false}>
{featuredSkillsWithText.length > 0 && (
<View style={{ ...styles.flexRowBetween, marginTop: spacing["0.5"] }}>
{featuredSkillsPair.map((pair, idx) => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const ResumePDFWorkExperience = ({
idx > 0 && company === workExperiences[idx - 1].company;

return (
<View key={idx} style={idx !== 0 ? { marginTop: spacing["2"] } : {}}>
<View wrap={false} key={idx} style={idx !== 0 ? { marginTop: spacing["2"] } : {}}>
{!hideCompanyName && (
<ResumePDFText bold={true}>{company}</ResumePDFText>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ if (typeof window !== "undefined" && window.location.hostname === "localhost") {
const consoleError = console.error;
const SUPPRESSED_WARNINGS = ["DOCUMENT", "PAGE", "TEXT", "VIEW"];
console.error = function filterWarnings(msg, ...args) {
if (!SUPPRESSED_WARNINGS.some((entry) => args[0]?.includes(entry))) {
const wrapFalse = Boolean(args[0] === "false" && args[1] === "wrap");
if (!SUPPRESSED_WARNINGS.some((entry) => args[0]?.includes(entry)) && !wrapFalse) {
consoleError(msg, ...args);
}
};
Expand Down
3 changes: 3 additions & 0 deletions src/app/components/Resume/ResumePDF/common/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,16 @@ export const ResumePDFSection = ({
heading,
style = {},
children,
wrap,
}: {
themeColor?: string;
heading?: string;
style?: Style;
children: React.ReactNode;
wrap?: boolean;
}) => (
<View
wrap={wrap}
style={{
...styles.flexCol,
gap: spacing["2"],
Expand Down

0 comments on commit 8a211d5

Please sign in to comment.