Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pals #205

Merged
merged 19 commits into from
Feb 19, 2025
Merged

Feat/pals #205

merged 19 commits into from
Feb 19, 2025

Conversation

Mukhammadali
Copy link
Collaborator

@Mukhammadali Mukhammadali commented Feb 10, 2025

Description

Changes:

  • Introduced PalsScreen with support for creating and managing AI assistants and roleplay characters
  • Added new components for Pals creation: AssistantPalSheet, RoleplayPalSheet, ModelSelector, FormField
  • Implemented PalStore for managing Pals data with persistence
  • Added new icons and updated existing components to support Pals functionality
  • Integrated Pals into navigation and sidebar
  • Updated theme and styling to support new Pals-related UI elements

Fixes #150
Fixes #214 (Llama.rn upgrade to 0.5.3-1)
Fixes #152 (Llama.rn upgrade to 0.5.3-1)

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani
Copy link
Owner

a-ghorbani commented Feb 11, 2025

  • Test fails due to: Jest: "global" coverage threshold for branches (60%) not met: 57.3%
  • We need to add 'delete' functionality for Pals.
  • [Bug] Edit pals – previous values do not persist when navigating away and returning to the Pals screen.
  • Roleplay prompt generator doesn't use models stop words
  • Add chevron to model selectors
  • Add text to the model selector indicating which models are best for prompt generation.
  • When there are many palls or downloaded models the sheet doesn't scroll up enough.
  • Add stop for ai prompt generator.
  • By selecting an active pal (or an explicit button for deactivation of a pal) it should deselect the pal.
  • When a pal is selected, a new chat should continue using the same pal.
  • [Bug] When no model has been downloaded, the empty chat page's "Download Model" button opens the Pals/Models sheet instead of directing to the Models page.
  • For the Pals object, we need to store the default model's basic information, including its name, oid, size, number of params, hf download url etc, so that we can use these info to display the default model yet notify the user when the model is not downloaded, and allow the user to download the model. The download process should be handled safely as it is done in the model page, ie checking storage space and monitoring for memory warnings, etc.
  • Add warning icon on pals card that the default model is not downloaded.

@a-ghorbani a-ghorbani merged commit 7d419e1 into main Feb 19, 2025
1 check passed
@a-ghorbani a-ghorbani deleted the feat/pals branch February 19, 2025 20:53
@a-ghorbani a-ghorbani restored the feat/pals branch February 20, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants