Allow it to be used without ActiveRecord being present #72
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-chacon
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Hey @hugomelo really thank you for your contribution! Please fix the syntax I indicated, and the PR could be merged. I recommend to you run Rubocop in your local before push your changes, so you can be sure that no problems will be.
Just let me know any problem or question, thank you again!
| @@ -60,7 +60,7 @@ def process_non_hash_content(content) | |||
| maybe_a_model, errors = content.gsub('@', "").split(".") | |||
| klass = maybe_a_model.singularize.camelize(:upper).constantize | |||
|
|
|||
| if klass.ancestors.include?(ActiveRecord::Base) | |||
| if klass.ancestors.map{|a| a.to_s }.include? 'ActiveRecord::Base' | |||
When you use include? ActiveRecord::Base, you expect that module/class is loaded. Changed the verification to use a text representation of the module
hugomelo
force-pushed
the
fix_active_record_error
branch
from
8e18573 to
04ca722
Compare
|
I have updated the commit |
a-chacon
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use
include? ActiveRecord::Base, you expect that module/class to be loaded. Changed the verification to use a text representation of the module