rules: add some tests to Java and JavaScript rules #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
lucasbrunozup
suggested changes
Oct 15, 2021
matheusalcantarazup
force-pushed
the
issue-630
branch
from
8d72a87
to
11787fa
Compare
iancardosozup
approved these changes
Oct 19, 2021
lucasbrunozup
approved these changes
Oct 19, 2021
Add tests to HS-JAVA-1, HS-JAVASCRIPT-1, HS-JAVASCRIPT-2 and HS-JAVASCRIPT-2 rules. This commit also make a improvement on HS-JAVASCRIPT-2 to match the correct way to set NODE_TLS_REJECT_UNAUTHORIZED env on Nodejs. Previously the rule was just match with the following code `"NODE_TLS_REJECT_UNAUTHORIZED" = "0";` with the change the rule will match `process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";` Update #630 Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
issue-630
branch
from
11787fa
to
1ba54d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to HS-JAVA-1, HS-JAVASCRIPT-1, HS-JAVASCRIPT-2 and
HS-JAVASCRIPT-2 rules.
This commit also make a improvement on HS-JAVASCRIPT-2 to match the
correct way to set NODE_TLS_REJECT_UNAUTHORIZED env on Nodejs.
Previously the rule was just match with the following code
"NODE_TLS_REJECT_UNAUTHORIZED" = "0";with the change the rule willmatch
process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";Update #630
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog