-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/figma variables integration without font change #43
Closed
lukecore
wants to merge
16
commits into
main
from
features/figma-variables-integration-without-font-change
Closed
Features/figma variables integration without font change #43
lukecore
wants to merge
16
commits into
main
from
features/figma-variables-integration-without-font-change
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* transform function * storybook plugin
…ated) component changes more visible.
…les-integration-without-font-change # Conflicts: # package-lock.json
6cec3bb
to
f5280ec
Compare
culas
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION THIS IS ONLY A DRAFT AND USED TO CHECK THE CHROMATIC BUILD
PLEASE DO NOT REVIEW IT (YET)
With the introduction of the new Design-tokens, the font has changed as well. Since this has impact on every component, this PR should be used to display the changes in Chromatic, without font changes. Therefore, I changed the font manually back to "Open Sans" instead of "Inter".
Missing:
Potential starting poins:
This change covers the changes made from Julio but removes the font change to make the impact on components better visible.