Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/figma variables integration without font change #43

Closed

Conversation

lukecore
Copy link
Collaborator

@lukecore lukecore commented Jul 17, 2024

ATTENTION THIS IS ONLY A DRAFT AND USED TO CHECK THE CHROMATIC BUILD

PLEASE DO NOT REVIEW IT (YET)

With the introduction of the new Design-tokens, the font has changed as well. Since this has impact on every component, this PR should be used to display the changes in Chromatic, without font changes. Therefore, I changed the font manually back to "Open Sans" instead of "Inter".

Missing:

  • The Snapshots still seem to use a back-up font. Figure out, why the fonts are not loaded anymore in Chromatic. A solution is already implemented in this PR but the Goal in this PR is to keep the old setup.

Potential starting poins:

This change covers the changes made from Julio but removes the font change to make the impact on components better visible.

@lukecore lukecore force-pushed the features/figma-variables-integration-without-font-change branch from 6cec3bb to f5280ec Compare August 9, 2024 06:45
@lukecore lukecore closed this Aug 9, 2024
@lukecore lukecore deleted the features/figma-variables-integration-without-font-change branch August 9, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants