Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format used for address parameter #5

Open
wants to merge 2 commits into
base: swap-cosmos-support
Choose a base branch
from
Open

Update format used for address parameter #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73095cd
TEMP use integration branch for cosmos tests
fbeutin-ledger Jan 13, 2025
b42a2a3
Remove expectation of leading byte in swap address parameter
fbeutin-ledger Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/reusable_swap_functional_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ on:

branch_for_cosmos:
required: false
default: 'main'
default: 'fbe/integrate_zondax_swap'
type: string
repo_for_cosmos:
required: false
default: 'cosmos/ledger-cosmos'
default: 'LedgerHQ/app-cosmos'
type: string

test_filter:
Expand Down
4 changes: 2 additions & 2 deletions test/python/apps/cosmos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from nacl.exceptions import BadSignatureError

from ragger.utils import create_currency_config
from ragger.bip import pack_derivation_path, bitcoin_pack_derivation_path, BtcDerivationPathFormat
from ragger.bip import pack_derivation_path
from ragger.error import ExceptionRAPDU
from scalecodec.base import RuntimeConfiguration
from scalecodec.type_registry import load_type_registry_preset
Expand All @@ -18,7 +18,7 @@
from ecdsa.util import string_to_number

COSMOS_CONF = create_currency_config("ATOM", "Cosmos")
COSMOS_PACKED_DERIVATION_PATH = bitcoin_pack_derivation_path(BtcDerivationPathFormat.LEGACY, "m/44'/118'/5'/0'/3")
COSMOS_PACKED_DERIVATION_PATH = pack_derivation_path("m/44'/118'/5'/0'/3")
COSMOS_PACKED_DERIVATION_PATH_SIGN_INIT = bytes([0x2c, 0x00, 0x00, 0x80,
0x76, 0x00, 0x00, 0x80,
0x05, 0x00, 0x00, 0x80,
Expand Down