shell=True might not be necessary

Zomato · Jul 6, 2020 · fb8b4c2 · fb8b4c2
1 parent 7d604ca
commit fb8b4c2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -21,8 +21,8 @@ def build_js() -> None:
         logging.error('npm must be available')
 
     try:
-        subprocess.check_call(['npm install'], cwd=PACKAGE_DIR, shell=True)
-        subprocess.check_call(['npm run build'], cwd=PACKAGE_DIR, shell=True)
+        subprocess.check_output(['npm install'], cwd=PACKAGE_DIR)
+        subprocess.check_call(['npm run build'], cwd=PACKAGE_DIR)
     except Exception as e:
         logging.warn('Installation of npm dependencies failed')
         logging.warn(str(e))